Skip to content

Use templated $NAME #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

Use templated $NAME #13

merged 1 commit into from
Jan 21, 2025

Conversation

kraangprime
Copy link
Contributor

Use templated ${NAME} instead of hardcoded name "App" when building on osx.

This enables cmake --build to pass when using custom application name eg set(NAME "MyCustomApp")

And thanks for nice template!

@kraangprime
Use templated ${NAME} instead of hardcoded name "app" when building o…
9c4a503 
…n osx

This enables cmake build to pass when using custom application name eg `set(NAME "MyCustomApp")`
@MartinHelmut
Copy link
Owner

Thank you, also for catching this and contributing! Much appreciated :D

@MartinHelmut MartinHelmut merged commit c846919 into MartinHelmut:main Jan 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kraangprime @MartinHelmut